----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25549/#review54627 -----------------------------------------------------------
src/slave/containerizer/isolators/filesystem/shared.cpp <https://reviews.apache.org/r/25549/#comment94861> why are the remount commands different for proc and sys? also, why do we need to remount /sys and /proc in the fs isolator? it's not clear to me from the "reflect namespace changes for the container processes". maybe expand on the comment? src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/25549/#comment94864> Hmm. Instead of returning an error here, how about just adding "filesystem/shared" isolator to the list of isolators in mesos containerizer, if either of "filesystem/shared" or "network/portmapping" is specified in flags? - Vinod Kone On Sept. 24, 2014, 6:09 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25549/ > ----------------------------------------------------------- > > (Updated Sept. 24, 2014, 6:09 p.m.) > > > Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-1586 > https://issues.apache.org/jira/browse/MESOS-1586 > > > Repository: mesos-git > > > Description > ------- > > Does not report usage or enforce quota but can create 'private' directories > for each container which mask parts of the shared host filesystem. > > This review replaces https://reviews.apache.org/r/24178/ because of some file > renaming. I addressed all comments from earlier reviews. > > > Diffs > ----- > > include/mesos/mesos.proto be45494b2c2f5c1295409889b70004462c6eba49 > src/Makefile.am 9b973e5503e30180045e270220987ba647da8038 > src/common/parse.hpp e6153d8a1f25bc9ddbe1e391306beeacfc8d5ff6 > src/common/type_utils.hpp 480c0883fe6ed7f6a9daf77d83ebb077da2e66ee > src/slave/containerizer/isolators/filesystem/shared.hpp PRE-CREATION > src/slave/containerizer/isolators/filesystem/shared.cpp PRE-CREATION > src/slave/containerizer/isolators/network/port_mapping.cpp > 2766a00ff81dc550c21387f920666f81705db4f0 > src/slave/containerizer/linux_launcher.cpp > f7bc894830a7ca3f55465dacc7b653cdc2d7758b > src/slave/containerizer/mesos/containerizer.cpp > 9d083294caa5c5a47ba3ceaa1b57346144cb795c > src/slave/flags.hpp 32e51d214b0dbbb2f106236c6fa42ddec9774585 > src/slave/slave.cpp 9a6646f0249fd43ae5d13bd9ee3aaaab5da08412 > src/tests/isolator_tests.cpp c38f87632cb6984543cb3767dbd656cde7459610 > src/tests/mesos.hpp 957e2233cc11c438fd80d3b6d1907a1223093104 > > Diff: https://reviews.apache.org/r/25549/diff/ > > > Testing > ------- > > make check # added a test > > > Thanks, > > Ian Downes > >
