> On Oct. 7, 2014, 2:44 p.m., Jie Yu wrote: > > src/slave/containerizer/isolators/filesystem/shared.cpp, lines 74-77 > > <https://reviews.apache.org/r/25549/diff/5/?file=711209#file711209line74> > > > > Should we check other error conditions as well? > > > > For example, `!executorInfo.has_container()`?
This is checked a few lines below and will return None(). > On Oct. 7, 2014, 2:44 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/containerizer.cpp, lines 434-440 > > <https://reviews.apache.org/r/25549/diff/5/?file=711211#file711211line434> > > > > This check is redundent, right? Redundant with what? This is returns false if launching a container with a ContainerInfo != MESOS. Do you mean the check in filesystem/shared.cpp is redundant? - Ian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25549/#review55689 ----------------------------------------------------------- On Oct. 2, 2014, 11:21 a.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25549/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2014, 11:21 a.m.) > > > Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-1586 > https://issues.apache.org/jira/browse/MESOS-1586 > > > Repository: mesos-git > > > Description > ------- > > Does not report usage or enforce quota but can create 'private' directories > for each container which mask parts of the shared host filesystem. > > This review replaces https://reviews.apache.org/r/24178/ because of some file > renaming. I addressed all comments from earlier reviews. > > > Diffs > ----- > > include/mesos/mesos.proto 735da535f136d1188d3c6cf47b2e11153dab6fc3 > src/Makefile.am 27c42dfde45a449750132e416b4eaf776f8c5e3b > src/common/parse.hpp e6153d8a1f25bc9ddbe1e391306beeacfc8d5ff6 > src/common/type_utils.hpp 480c0883fe6ed7f6a9daf77d83ebb077da2e66ee > src/slave/containerizer/isolators/filesystem/shared.hpp PRE-CREATION > src/slave/containerizer/isolators/filesystem/shared.cpp PRE-CREATION > src/slave/containerizer/linux_launcher.cpp > f7bc894830a7ca3f55465dacc7b653cdc2d7758b > src/slave/containerizer/mesos/containerizer.cpp > 9d083294caa5c5a47ba3ceaa1b57346144cb795c > src/slave/flags.hpp 16f0cc2ab5ba16a39499608174278b3082e0585d > src/slave/slave.cpp e56dcbd80114730949a0d4b553470802a4d38281 > src/tests/isolator_tests.cpp c38f87632cb6984543cb3767dbd656cde7459610 > src/tests/mesos.hpp 957e2233cc11c438fd80d3b6d1907a1223093104 > > Diff: https://reviews.apache.org/r/25549/diff/ > > > Testing > ------- > > make check # added a test > > > Thanks, > > Ian Downes > >
