----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26090/#review54824 -----------------------------------------------------------
Ship it! Looks great! A few style nits. Please update the review and I'll commit this. src/slave/containerizer/isolators/network/port_mapping.hpp <https://reviews.apache.org/r/26090/#comment95110> Reorder s and containerId src/slave/containerizer/isolators/network/port_mapping.hpp <https://reviews.apache.org/r/26090/#comment95108> Adjust the comment. s/usage/statistics/ src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/26090/#comment95111> Remove extra space before %. src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/26090/#comment95114> Add a NOTE: src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/26090/#comment95117> Add a blank line above. src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/26090/#comment95118> Add a TODO here. src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/26090/#comment95120> This fits in one line? - Jie Yu On Sept. 27, 2014, 12:34 a.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26090/ > ----------------------------------------------------------- > > (Updated Sept. 27, 2014, 12:34 a.m.) > > > Review request for mesos, Ian Downes, Jie Yu, and Cong Wang. > > > Bugs: mesos-1808 > https://issues.apache.org/jira/browse/mesos-1808 > > > Repository: mesos-git > > > Description > ------- > > see summary. > > > Diffs > ----- > > include/mesos/mesos.proto be45494 > src/slave/containerizer/isolators/network/helper.cpp 6cbcb33 > src/slave/containerizer/isolators/network/port_mapping.hpp b624c4d > src/slave/containerizer/isolators/network/port_mapping.cpp 2766a00 > > Diff: https://reviews.apache.org/r/26090/diff/ > > > Testing > ------- > > > Thanks, > > Chi Zhang > >
