----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26090/#review55134 -----------------------------------------------------------
The test looks good. See my comments. src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/26090/#comment95508> Add a new line above src/tests/port_mapping_tests.cpp <https://reviews.apache.org/r/26090/#comment95525> Could you also split the tests? We rarely merge two functionality tests into one unit test. src/tests/port_mapping_tests.cpp <https://reviews.apache.org/r/26090/#comment95527> Could you comment on why using seconds(5) here? Also, this test runs too long. Could you please reduce its running time? - Jie Yu On Oct. 1, 2014, 6:01 p.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26090/ > ----------------------------------------------------------- > > (Updated Oct. 1, 2014, 6:01 p.m.) > > > Review request for mesos, Ian Downes, Jie Yu, and Cong Wang. > > > Bugs: mesos-1808 > https://issues.apache.org/jira/browse/mesos-1808 > > > Repository: mesos-git > > > Description > ------- > > see summary. > > > Diffs > ----- > > include/mesos/mesos.proto 735da53 > src/slave/containerizer/isolators/network/helper.cpp 6cbcb33 > src/slave/containerizer/isolators/network/port_mapping.hpp 2395ec2 > src/slave/containerizer/isolators/network/port_mapping.cpp 8ddfb18 > src/tests/port_mapping_tests.cpp 0389f40 > > Diff: https://reviews.apache.org/r/26090/diff/ > > > Testing > ------- > > both manually tested and with a unit test. > > > Thanks, > > Chi Zhang > >
