On Mon, Sep 29, 2014 at 2:24 PM, Cody Maloney <c...@mesosphere.io> wrote:
> > > > On Sept. 29, 2014, 9:13 p.m., Dominic Hamon wrote: > > > we check in configure in mesos, not in stout. we'd have to bubble > those c++11 checks down the stack through libprocess and into stout before > we can responsibly deprecate this (and other) c++11 guards. > > We already use them in stout unconditionally at this point given > https://reviews.apache.org/r/25789/ That doesn't make it right, just means that that review shouldn't have shipped without the configure change in stout :) So this time, let's do it right and make sure people configuring stout have the right compiler. > > > > - Cody > > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26147/#review54876 > ----------------------------------------------------------- > > > On Sept. 29, 2014, 8:47 p.m., Cody Maloney wrote: > > > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > https://reviews.apache.org/r/26147/ > > ----------------------------------------------------------- > > > > (Updated Sept. 29, 2014, 8:47 p.m.) > > > > > > Review request for mesos and Dominic Hamon. > > > > > > Repository: mesos-git > > > > > > Description > > ------- > > > > Variadic templates are required in configure, so we don't need to be > condtional around their use in strings::format > > > > > > Diffs > > ----- > > > > 3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp > 58ab7424c9645fd04d6aea2e4ff56c1ff9815953 > > > > Diff: https://reviews.apache.org/r/26147/diff/ > > > > > > Testing > > ------- > > > > Make check on Ubuntu 14.04 > > > > > > Thanks, > > > > Cody Maloney > > > > > > -- Dominic Hamon | @mrdo | Twitter *There are no bad ideas; only good ideas that go horribly wrong.*
