> On Sept. 29, 2014, 2:13 p.m., Dominic Hamon wrote: > > we check in configure in mesos, not in stout. we'd have to bubble those > > c++11 checks down the stack through libprocess and into stout before we can > > responsibly deprecate this (and other) c++11 guards. > > Cody Maloney wrote: > We already use them in stout unconditionally at this point given > https://reviews.apache.org/r/25789/ > > Cody Maloney wrote: > We also have been using libstdc++/libc++ tuples which depend on variadic > templates in their implementatinos for quite a while inside libprocess.
That's unfortunate, but we should go back and fix that bad state. - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26147/#review54876 ----------------------------------------------------------- On Sept. 29, 2014, 2:40 p.m., Cody Maloney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26147/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2014, 2:40 p.m.) > > > Review request for mesos, Benjamin Hindman and Dominic Hamon. > > > Repository: mesos-git > > > Description > ------- > > Variadic templates are required in configure, so we don't need to be > condtional around their use in strings::format > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp > 58ab7424c9645fd04d6aea2e4ff56c1ff9815953 > > Diff: https://reviews.apache.org/r/26147/diff/ > > > Testing > ------- > > Make check on Ubuntu 14.04 > > > Thanks, > > Cody Maloney > >
