> On Oct. 1, 2014, 1:35 p.m., Benjamin Hindman wrote: > > src/module/manager.cpp, line 59 > > <https://reviews.apache.org/r/25848/diff/12/?file=709886#file709886line59> > > > > Maybe I'm just getting a big grumpy, but I'm really not in favor of > > overloading the term 'role' here. We've overloaded terms a handful of times > > in Mesos/libprocess and it has never turned out well. Moreover, by calling > > this a 'role' we're somehow implying that it's something more than just a > > type, yet when I look at the possible "roles" suggested here these are just > > types, Isolator, Authenticator, Allocator, etc. What's the benefit of > > introducing a new term for this that we need to define for people and > > they'll have to remember? > > Kapil Arya wrote: > Bernd/Nik: We have been talking about finding a better name anyways. Any > ideas?
I suggested 'kind' before - Niklas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25848/#review55065 ----------------------------------------------------------- On Oct. 1, 2014, 4:18 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25848/ > ----------------------------------------------------------- > > (Updated Oct. 1, 2014, 4:18 p.m.) > > > Review request for mesos, Benjamin Hindman, Bernd Mathiske, Niklas Nielsen, > and Timothy St. Clair. > > > Bugs: MESOS-1384 > https://issues.apache.org/jira/browse/MESOS-1384 > > > Repository: mesos-git > > > Description > ------- > > Adding a first class primitive, abstraction and process for dynamic library > writing and loading can make it easier to extend inner workings of Mesos. > Making it possible to have dynamic loadable resource allocators, isolators, > containerizes, authenticators and much more. > > > Diffs > ----- > > configure.ac 86d448c3ad00ad01d3d069c1039dc7ad524af567 > include/mesos/module.hpp.in PRE-CREATION > src/Makefile.am e588fd0298f43e44ba01a2b0c907145b801ff1c2 > src/examples/test_module.hpp PRE-CREATION > src/examples/test_module_impl.cpp PRE-CREATION > src/examples/test_module_impl2.cpp PRE-CREATION > src/module/manager.hpp PRE-CREATION > src/module/manager.cpp PRE-CREATION > src/tests/module_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/25848/diff/ > > > Testing > ------- > > Ran make check with added tests for verifying library/module loading and > simple version check. > > > Thanks, > > Kapil Arya > >
