----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26476/#review55977 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp <https://reviews.apache.org/r/26476/#comment96328> std::unique_ptr would also be an option as it can be moved on Option copy. Would that be a less intrusive change? - Dominic Hamon On Oct. 8, 2014, 6:35 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26476/ > ----------------------------------------------------------- > > (Updated Oct. 8, 2014, 6:35 p.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > Remove dynamic allocations from Option class. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 47fe92c > > Diff: https://reviews.apache.org/r/26476/diff/ > > > Testing > ------- > > make check > support/mesos-style.py > valgrind (reduced allocation count) > > > Thanks, > > Joris Van Remoortere > >
