----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26476/#review60162 -----------------------------------------------------------
Seems this one got stuck for a while now. The reasons appear to be founded in the doubts expressed in the above reviews. I would highly recommend creating a JIRA (if there is none yet), find a shepherd and document the above concerns and your argumentation in such JIRA. These points would most likely also form a great base for further optimizing in similar cases. - Till Toenshoff On Oct. 22, 2014, 7:34 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26476/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2014, 7:34 p.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > Remove dynamic allocations from Option class. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 47fe92c > > Diff: https://reviews.apache.org/r/26476/diff/ > > > Testing > ------- > > make check > support/mesos-style.py > valgrind (reduced allocation count) > > > Thanks, > > Joris Van Remoortere > >
