> On Oct. 9, 2014, 9:39 p.m., Ben Mahler wrote: > > docs/mesos-c++-style-guide.md, lines 98-101 > > <https://reviews.apache.org/r/25622/diff/6/?file=716711#file716711line98> > > > > Why 'valueIt' here but 'i' below? How about 'i' in both cases?
Ben, would you also update https://mesos.apache.org/documentation/latest/mesos-c++-style-guide/? And please check if the issue mentioned by MPark is gone away with this patch. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25622/#review56058 ----------------------------------------------------------- On Oct. 10, 2014, 2:12 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25622/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2014, 2:12 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Dominic Hamon, and > Till Toenshoff. > > > Bugs: MESOS-1793 > https://issues.apache.org/jira/browse/MESOS-1793 > > > Repository: mesos-git > > > Description > ------- > > Explicitly prohibit the use of namespace aliases. Give examples of preferable > way of using auto. > > > Diffs > ----- > > docs/mesos-c++-style-guide.md 59a39df > > Diff: https://reviews.apache.org/r/25622/diff/ > > > Testing > ------- > > Documentation change, no `make check` needed. > > > Thanks, > > Alexander Rukletsov > >
