----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26535/#review56188 -----------------------------------------------------------
src/master/registrar.cpp <https://reviews.apache.org/r/26535/#comment96512> we should probably stop the timer whether the recovery succeeded or failed. maybe we need a 'cancel' method on the timer? - Dominic Hamon On Oct. 10, 2014, 11:25 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26535/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2014, 11:25 a.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > We currently lack logging visibility into the batch sizes in the registrar. > > While we have timing metrics, we also lack the ability to easily read timings > for particular operations. > > > Diffs > ----- > > src/master/registrar.cpp ccc2fd23b1a1d56ab327cc73f6fef35d4bf6a552 > > Diff: https://reviews.apache.org/r/26535/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
