> On Oct. 10, 2014, 6:27 p.m., Dominic Hamon wrote: > > src/master/registrar.cpp, line 341 > > <https://reviews.apache.org/r/26535/diff/2/?file=717559#file717559line341> > > > > we should probably stop the timer whether the recovery succeeded or > > failed. maybe we need a 'cancel' method on the timer?
I thought about this, is there any value in including the timing of failures? At least for the registrar, the point is moot since we'll fail the master. More generally, since 'start()' will reset the timer, it seems safe to exclude certain timings (e.g. failures) by not calling stop() for these cases. Thoughts? - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26535/#review56188 ----------------------------------------------------------- On Oct. 10, 2014, 6:25 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26535/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2014, 6:25 p.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > We currently lack logging visibility into the batch sizes in the registrar. > > While we have timing metrics, we also lack the ability to easily read timings > for particular operations. > > > Diffs > ----- > > src/master/registrar.cpp ccc2fd23b1a1d56ab327cc73f6fef35d4bf6a552 > > Diff: https://reviews.apache.org/r/26535/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
