> On Sept. 30, 2014, 4:48 p.m., Jie Yu wrote: > >
Thanks for the great review Jie! > On Sept. 30, 2014, 4:48 p.m., Jie Yu wrote: > > 3rdparty/libprocess/3rdparty/Makefile.am, lines 188-189 > > <https://reviews.apache.org/r/24535/diff/2/?file=708151#file708151line188> > > > > Should we add some check in configure.ac? Also, seems that not all > > distributions install headers under apr-1: > > > > http://packages.ubuntu.com/trusty/amd64/libaprutil1-dev/filelist Tim Chen has done that in https://reviews.apache.org/r/26214. > On Sept. 30, 2014, 4:48 p.m., Jie Yu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/svn.hpp, line 41 > > <https://reviews.apache.org/r/24535/diff/2/?file=708152#file708152line41> > > > > Do we need to do the pool allocation everytime? Or could we just do it > > once? I am not sure whether would cause any performance issue or not. Unfortunately I don't know how to deallocate any memory that might have been allocated by functions that I passed the pool to, thus, I need to destroy the pool at the end of these functions and create a new one at the beginning (otherwise, IIUC, the pool will grow unbounded). > On Sept. 30, 2014, 4:48 p.m., Jie Yu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/svn.hpp, line 53 > > <https://reviews.apache.org/r/24535/diff/2/?file=708152#file708152line53> > > > > This seems to be deprecated. > > > > http://subversion.apache.org/docs/api/latest/group__svn__delta__txt__delta.html#gaf7354f923339d3338c3083e91bfee472 > > > > Consider using svn_txdelta_to_svndiff3? Tim Chen replaced the use of these in https://reviews.apache.org/r/26214. > On Sept. 30, 2014, 4:48 p.m., Jie Yu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/svn.hpp, line 80 > > <https://reviews.apache.org/r/24535/diff/2/?file=708152#file708152line80> > > > > destroy pool before return? Thank you thank you! - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24535/#review54857 ----------------------------------------------------------- On Oct. 12, 2014, 4:14 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24535/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2014, 4:14 a.m.) > > > Review request for mesos, Ben Mahler and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > Note that this hard codes the location of the subversion and Apache Portable > Runtime (APR) headers. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/Makefile.am > 256df0bb5557ebe6c75099d35c284804c9e57253 > 3rdparty/libprocess/3rdparty/stout/include/stout/svn.hpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/tests/svn_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/24535/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
