> On Oct. 15, 2014, 12:22 a.m., Ben Mahler wrote: > > Looks good modulo some issues below, would like to take a final pass when > > you update the APR() abstraction to be thread safe. > > Ben Mahler wrote: > Hm.. have you looked at whether the other calls here are thread safe? > > For example, svn_pool_create().
Yes, according to http://goo.gl/NX0hps, apr_pool_create_ex is thread safe, which is what svn_pool_create calls (through svn_pool_create_ex). I added a comment and pointed to this documentation. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24535/#review56597 ----------------------------------------------------------- On Oct. 25, 2014, 11:18 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24535/ > ----------------------------------------------------------- > > (Updated Oct. 25, 2014, 11:18 p.m.) > > > Review request for mesos, Ben Mahler and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > Note that this hard codes the location of the subversion and Apache Portable > Runtime (APR) headers. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/Makefile.am > 1e24886628d07a788385e5056f05869b373d970a > 3rdparty/libprocess/3rdparty/stout/Makefile.am > 41360620ee28bd2fca50f4b57ebe5803b10437cf > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > d5290130a5864aa38dc6aadb0d9664efb1424488 > 3rdparty/libprocess/3rdparty/stout/include/stout/svn.hpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/tests/svn_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/24535/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
