----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26766/#review56897 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp <https://reviews.apache.org/r/26766/#comment97336> Like you said { "", "" } really means the same as { "" }, so let's just simplify the code and use the while loop below. - Timothy Chen On Oct. 15, 2014, 6:46 p.m., Cody Maloney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26766/ > ----------------------------------------------------------- > > (Updated Oct. 15, 2014, 6:46 p.m.) > > > Review request for mesos and Timothy Chen. > > > Bugs: MESOS-1878 > https://issues.apache.org/jira/browse/MESOS-1878 > > > Repository: mesos-git > > > Description > ------- > > Adds 3 new functions: asAbsolute, clean, and split(). All three were > hand-coded inside of mesos files (files/files.cpp). This puts them in a > common place, and adds unit tests for their behavior. > > The functions depend on eachother somewhat, so I pulled out the declarations > to make them all forward declared. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp > 357a75a8bac497465671456aa9cd9181123cc635 > 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp > aedf93573ea89e46bf7b7b91f2258049af2fd79f > > Diff: https://reviews.apache.org/r/26766/diff/ > > > Testing > ------- > > make distcheck > > > Thanks, > > Cody Maloney > >
