> On Oct. 17, 2014, 9:30 p.m., Ben Mahler wrote: > > src/messages/messages.proto, lines 76-78 > > <https://reviews.apache.org/r/26700/diff/3/?file=723861#file723861line76> > > > > Looks like you wrote this comment before it was moved down to the > > variable, no need to write 'latest_state' anymore right? > > > > Some more substance to this comment would be nice for posterity, i.e. > > what is it that makes this state different from the one in TaskStatus?
done. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26700/#review57219 ----------------------------------------------------------- On Oct. 17, 2014, 12:30 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26700/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2014, 12:30 a.m.) > > > Review request for mesos, Adam B, Ben Mahler, and Niklas Nielsen. > > > Bugs: MESOS-1799 and MESOS-1817 > https://issues.apache.org/jira/browse/MESOS-1799 > https://issues.apache.org/jira/browse/MESOS-1817 > > > Repository: mesos-git > > > Description > ------- > > Status update manager now sends both latest and unacknowledged states to the > master. > > > Diffs > ----- > > src/messages/messages.proto 8de7f9699f43aa2780f4a39fed087abcf5e5af99 > src/slave/slave.cpp 0e342ed35e3db3b68f9f32b6cf4ace23e4a4db38 > src/tests/status_update_manager_tests.cpp > e9ef1e208cb01535e9366db7872b922c8f06ec40 > > Diff: https://reviews.apache.org/r/26700/diff/ > > > Testing > ------- > > make check > > Ran new test 1000 times. > > > Thanks, > > Vinod Kone > >
