> On Oct. 17, 2014, 7:25 p.m., Jie Yu wrote: > > src/slave/slave.cpp, lines 2335-2337 > > <https://reviews.apache.org/r/26700/diff/3/?file=723862#file723862line2335> > > > > Use `void Slave::forward(StatusUpdate update)` and avoid the explicit > > copy.
I typically do/did explicit copy because it is more explicit than changing the argument type to non const. Do we follow a consistent pattern regarding this use case before? - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26700/#review57198 ----------------------------------------------------------- On Oct. 20, 2014, 11:55 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26700/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2014, 11:55 p.m.) > > > Review request for mesos, Adam B, Ben Mahler, and Niklas Nielsen. > > > Bugs: MESOS-1799 and MESOS-1817 > https://issues.apache.org/jira/browse/MESOS-1799 > https://issues.apache.org/jira/browse/MESOS-1817 > > > Repository: mesos-git > > > Description > ------- > > Status update manager now sends both latest and unacknowledged states to the > master. > > > Diffs > ----- > > src/messages/messages.proto 0dfc1b78dcf728bbf2b6094fb6111400c7af7362 > src/slave/slave.cpp 7b5474ae898f369fc55670cf1dbbee684bc0ae4b > src/tests/status_update_manager_tests.cpp > e9ef1e208cb01535e9366db7872b922c8f06ec40 > > Diff: https://reviews.apache.org/r/26700/diff/ > > > Testing > ------- > > make check > > Ran new test 1000 times. > > > Thanks, > > Vinod Kone > >
