> On Oct. 23, 2014, 9:20 p.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [27111] > > > > Failed command: ./support/apply-review.sh -n -r 27111 > > > > Error: > > --2014-10-23 21:20:04-- https://reviews.apache.org/r/27111/diff/raw/ > > Resolving reviews.apache.org (reviews.apache.org)... 140.211.11.74 > > Connecting to reviews.apache.org (reviews.apache.org)|140.211.11.74|:443... > > connected. > > HTTP request sent, awaiting response... 200 OK > > Length: 26290 (26K) [text/x-patch] > > Saving to: '27111.patch' > > > > 0K .......... .......... ..... 100% > > 780K=0.03s > > > > 2014-10-23 21:20:04 (780 KB/s) - '27111.patch' saved [26290/26290] > > > > Successfully applied: Block IO Isolator: usage metrics > > > > Implement a block io isolator that just publishes read / write, bytes / > > operations per second. > > A split of r25922 as suggested by Ian. > > > > > > Review: https://reviews.apache.org/r/27111 > > Checking 8 files using filter > > --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/operators,+whitespace/semicolon,+whitespace/tab,+whitespace/todo > > src/tests/isolator_tests.cpp:910: Could not find a newline character at > > the end of the file. [whitespace/ending_newline] [5] > > src/slave/containerizer/isolators/cgroups/blkio.cpp:217: Redundant blank > > line at the start of a code block should be deleted. > > [whitespace/blank_line] [2] > > Total errors found: 2 > > Failed to commit patch
Are you using the commit hook in support/ ? - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27111/#review58109 ----------------------------------------------------------- On Oct. 23, 2014, 9:58 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27111/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2014, 9:58 p.m.) > > > Review request for mesos, Benjamin Hindman and Ian Downes. > > > Bugs: MESOS-1977 > https://issues.apache.org/jira/browse/MESOS-1977 > > > Repository: mesos-git > > > Description > ------- > > Implement a block io isolator that just publishes read / write, bytes / > operations per second. > A split of r25922 as suggested by Ian. > > > Diffs > ----- > > include/mesos/mesos.proto 6b93e90 > src/Makefile.am 2617f77 > src/linux/cgroups.hpp abf31df > src/linux/cgroups.cpp 62df4b7 > src/linux/fs.hpp ac8b5f4 > src/linux/fs.cpp b01d14c > src/slave/containerizer/isolators/cgroups/blkio.hpp PRE-CREATION > src/slave/containerizer/isolators/cgroups/blkio.cpp PRE-CREATION > src/slave/containerizer/mesos/containerizer.cpp 9d08329 > src/tests/isolator_tests.cpp 52b38a3 > > Diff: https://reviews.apache.org/r/27111/diff/ > > > Testing > ------- > > make check > sudo ./mesos-tests --gtest_filter="BlkIOIsolatorTest*" > > > Thanks, > > Joris Van Remoortere > >
