----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27111/#review58524 -----------------------------------------------------------
Patch looks great! Reviews applied: [27111] All tests passed. - Mesos ReviewBot On Oct. 25, 2014, 5:53 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27111/ > ----------------------------------------------------------- > > (Updated Oct. 25, 2014, 5:53 p.m.) > > > Review request for mesos, Benjamin Hindman and Ian Downes. > > > Bugs: MESOS-1977 > https://issues.apache.org/jira/browse/MESOS-1977 > > > Repository: mesos-git > > > Description > ------- > > Implement a block io isolator that just publishes read / write, bytes / > operations per second. > A split of r25922 as suggested by Ian. > > > Diffs > ----- > > include/mesos/mesos.proto 6b93e90 > src/Makefile.am 2617f77 > src/linux/cgroups.hpp abf31df > src/linux/cgroups.cpp 62df4b7 > src/linux/fs.hpp ac8b5f4 > src/linux/fs.cpp b01d14c > src/slave/containerizer/isolators/cgroups/blkio.hpp PRE-CREATION > src/slave/containerizer/isolators/cgroups/blkio.cpp PRE-CREATION > src/slave/containerizer/mesos/containerizer.cpp 9d08329 > src/tests/isolator_tests.cpp 52b38a3 > > Diff: https://reviews.apache.org/r/27111/diff/ > > > Testing > ------- > > make check > sudo ./mesos-tests --gtest_filter="BlkIOIsolatorTest*" > > > Thanks, > > Joris Van Remoortere > >