----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27122/#review58253 -----------------------------------------------------------
Looks good. Just a couple of header guards and namespaces left to rename. I assume you didn't actually change any code logic in this patch. Please tell me if you did, and I will review those parts more closely. src/authentication/cram_md5/authenticatee.hpp <https://reviews.apache.org/r/27122/#comment99211> New namespace? src/authentication/cram_md5/authenticatee.hpp <https://reviews.apache.org/r/27122/#comment99212> s/2/1/ (Was a bug before, but is worth fixing here) src/authentication/cram_md5/authenticator.hpp <https://reviews.apache.org/r/27122/#comment99213> s/SASL/CRAMMD5/ src/authentication/cram_md5/authenticator.hpp <https://reviews.apache.org/r/27122/#comment99214> namespace cram_md5 {? src/authentication/cram_md5/auxprop.hpp <https://reviews.apache.org/r/27122/#comment99215> s/SASL/CRAMMD5/ src/authentication/cram_md5/auxprop.hpp <https://reviews.apache.org/r/27122/#comment99216> namespace cram_md5 src/authentication/cram_md5/auxprop.cpp <https://reviews.apache.org/r/27122/#comment99217> namespace cram_md5 { src/tests/crammd5_authentication_tests.cpp <https://reviews.apache.org/r/27122/#comment99218> namespace cram_md5? - Adam B On Oct. 23, 2014, 6:32 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27122/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2014, 6:32 p.m.) > > > Review request for mesos, Adam B and Vinod Kone. > > > Bugs: MESOS-1893 > https://issues.apache.org/jira/browse/MESOS-1893 > > > Repository: mesos-git > > > Description > ------- > > For paving the way into further authentication mechanism implementations, the > existing is reorganized. > > Move src/sasl to src/authentication/cram_md5, rename src/tests/sasl_tests.cpp > to src/tests/crammd5_authentication_tests.cpp. > Adapt depending include paths. > Rename specific test implementations from SASL to CRAMMD5Authentication. > > > Diffs > ----- > > src/Makefile.am 2617f77 > src/authentication/cram_md5/authenticatee.hpp PRE-CREATION > src/authentication/cram_md5/authenticator.hpp PRE-CREATION > src/authentication/cram_md5/auxprop.hpp PRE-CREATION > src/authentication/cram_md5/auxprop.cpp PRE-CREATION > src/master/master.cpp 95589b8 > src/sasl/authenticatee.hpp ec2c841 > src/sasl/authenticator.hpp 6f4d3db > src/sasl/auxprop.hpp 44e201b > src/sasl/auxprop.cpp 6de1222 > src/sched/sched.cpp e89e5e5 > src/scheduler/scheduler.cpp fb88a3e > src/slave/slave.cpp 55e5264 > src/tests/crammd5_authentication_tests.cpp PRE-CREATION > src/tests/sasl_tests.cpp 30556fa > > Diff: https://reviews.apache.org/r/27122/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Till Toenshoff > >
