----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27122/#review58910 -----------------------------------------------------------
A fly-by review, mostly about the file naming and include guards. src/Makefile.am <https://reviews.apache.org/r/27122/#comment100083> Why don't we call the file "cram_md5_authentication_tests.cpp"? The directory name is also cram_md5. src/authentication/cram_md5/authenticatee.hpp <https://reviews.apache.org/r/27122/#comment100082> %s/CRAMMD5/AUTHENTICATION_CRAM_MD5/ ? src/authentication/cram_md5/authenticatee.hpp <https://reviews.apache.org/r/27122/#comment100088> s/authoriation/authorization/ ? src/authentication/cram_md5/authenticator.hpp <https://reviews.apache.org/r/27122/#comment100090> s/CRAMMD5/AUTHENTICATION_CRAM_MD5/ ? src/authentication/cram_md5/authenticator.hpp <https://reviews.apache.org/r/27122/#comment100091> Reverse the #include order to alphabetize. src/authentication/cram_md5/authenticator.hpp <https://reviews.apache.org/r/27122/#comment100092> Same as the include guard. src/authentication/cram_md5/auxprop.hpp <https://reviews.apache.org/r/27122/#comment100093> s/CRAMMD5/AUTHENTICATION/CRAM_MD5/ ? src/authentication/cram_md5/auxprop.cpp <https://reviews.apache.org/r/27122/#comment100094> License blob missing. - Kapil Arya On Oct. 25, 2014, 9:21 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27122/ > ----------------------------------------------------------- > > (Updated Oct. 25, 2014, 9:21 a.m.) > > > Review request for mesos, Adam B and Vinod Kone. > > > Bugs: MESOS-1893 > https://issues.apache.org/jira/browse/MESOS-1893 > > > Repository: mesos-git > > > Description > ------- > > For paving the way into further authentication mechanism implementations, the > existing is reorganized. > > Move src/sasl to src/authentication/cram_md5, rename src/tests/sasl_tests.cpp > to src/tests/crammd5_authentication_tests.cpp. > Adapt depending include paths. > Rename specific test implementations from SASL to CRAMMD5Authentication. > Rename sasl namespace to cram_md5 throughout all uses. > > > Diffs > ----- > > src/Makefile.am 2617f77 > src/authentication/cram_md5/authenticatee.hpp PRE-CREATION > src/authentication/cram_md5/authenticator.hpp PRE-CREATION > src/authentication/cram_md5/auxprop.hpp PRE-CREATION > src/authentication/cram_md5/auxprop.cpp PRE-CREATION > src/master/master.hpp b1a2cd0 > src/master/master.cpp 95589b8 > src/sasl/authenticatee.hpp ec2c841 > src/sasl/authenticator.hpp 6f4d3db > src/sasl/auxprop.hpp 44e201b > src/sasl/auxprop.cpp 6de1222 > src/sched/sched.cpp e89e5e5 > src/scheduler/scheduler.cpp fb88a3e > src/slave/slave.hpp eb5de73 > src/slave/slave.cpp 55e5264 > src/tests/crammd5_authentication_tests.cpp PRE-CREATION > src/tests/sasl_tests.cpp 30556fa > > Diff: https://reviews.apache.org/r/27122/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Till Toenshoff > >
