----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27023/ -----------------------------------------------------------
(Updated Oct. 29, 2014, 4:31 a.m.) Review request for mesos, Benjamin Hindman and Niklas Nielsen. Changes ------- Add get() function which instantiates the impl if it was not already (e.g. implicit int conversion after default Socket() constructor). Add create() function which returns a new shared_ptr (RVO) to make the get() function a good candidate for inlining. Repository: mesos-git Description ------- Use std::shared_ptr to do reference counting for libprocess rather than manually doing it. Diffs (updated) ----- 3rdparty/libprocess/include/process/socket.hpp 6683881 Diff: https://reviews.apache.org/r/27023/diff/ Testing (updated) ------- make check Thanks, Joris Van Remoortere