----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27023/#review61019 -----------------------------------------------------------
3rdparty/libprocess/include/process/socket.hpp <https://reviews.apache.org/r/27023/#comment102471> Will this drop down to interger comparison or do we need an overload on impl too? 3rdparty/libprocess/include/process/socket.hpp <https://reviews.apache.org/r/27023/#comment102472> Can we make the test explicit (taken that impl isn't a bool?) Also, I wouldn't mind if you expanded this as you are doing work (create()) in a ternary statement. Don't feel very strong about that, but I have an easier time reading it :) 3rdparty/libprocess/include/process/socket.hpp <https://reviews.apache.org/r/27023/#comment102470> If you included stout, then use memory::shared_ptr? I couldn't find any other place in libprocess where we use std::shared_ptr (but I think it reads odd together with std::make_shared). If we are to change this, we should probably preceed this patch with an update to the style guide about whitelisting std::shared_ptr. What do you think? Can you expand on why you needed to make it mutable? - Niklas Nielsen On Oct. 28, 2014, 10:10 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27023/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2014, 10:10 p.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > Use std::shared_ptr to do reference counting for libprocess rather than > manually doing it. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/socket.hpp 6683881 > > Diff: https://reviews.apache.org/r/27023/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joris Van Remoortere > >
