----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27315/#review59034 -----------------------------------------------------------
src/sched/sched.cpp <https://reviews.apache.org/r/27315/#comment100315> the two places this is referenced it is doubled. Please add a comment why or just store the doubled factor somewhere to simplify the readability of the code. src/sched/sched.cpp <https://reviews.apache.org/r/27315/#comment100313> maybe set this on line 503 and then override if necessary. This ensures it is set and is clearer to read. src/sched/sched.cpp <https://reviews.apache.org/r/27315/#comment100314> it looks like you derefence this everywhere.. so why did it need to become a pointer? Why not a concrete instance member variable? - Dominic Hamon On Oct. 28, 2014, 4:08 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27315/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2014, 4:08 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1903 > https://issues.apache.org/jira/browse/MESOS-1903 > > > Repository: mesos-git > > > Description > ------- > > Uses the same backoff (except no initial backoff) strategy used by the slave > during registration. > > > Diffs > ----- > > include/mesos/scheduler.hpp 42e4e279d059801cd85955fd04995b60051a2b5e > src/Makefile.am 374f284e1ac839fbcd8a28171b1ff4fbe8a17bd4 > src/local/constants.hpp PRE-CREATION > src/local/constants.cpp PRE-CREATION > src/local/flags.hpp 54e88319afc68007ff5d7c0d0179b685ef845c87 > src/sched/sched.cpp 0fb8c7bda75545389f8024489b3c76ae115111f4 > src/tests/fault_tolerance_tests.cpp > a18a41a3e34ff112e04e693447d757403e5013bd > > Diff: https://reviews.apache.org/r/27315/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
