> On Oct. 29, 2014, 2:43 a.m., Cody Maloney wrote: > > src/sched/sched.cpp, line 506 > > <https://reviews.apache.org/r/27315/diff/1/?file=736571#file736571line506> > > > > maxBackoff is never set if duration.isNone.
good catch! thanks. fixed. > On Oct. 29, 2014, 2:43 a.m., Cody Maloney wrote: > > include/mesos/scheduler.hpp, line 443 > > <https://reviews.apache.org/r/27315/diff/1/?file=736566#file736566line443> > > > > It would be more precise to use an Optional here rather than write the > > rules/semantics (if I'm reading the rest of the code correctly) into a > > pointer. > > > > Also means we don't have to manually clean up in the destructor. i restructured the code and this is n/a. > On Oct. 29, 2014, 2:43 a.m., Cody Maloney wrote: > > src/sched/sched.cpp, line 519 > > <https://reviews.apache.org/r/27315/diff/1/?file=736571#file736571line519> > > > > It would be nice to use <random> here (The headers at least are around > > in gcc 4.4). > > > > Doing this sort of math creates significantly biased randon numbers. added a TODO for now. i can fix it here and in slave in a subsequent review. > On Oct. 29, 2014, 2:43 a.m., Cody Maloney wrote: > > src/sched/sched.cpp, line 522 > > <https://reviews.apache.org/r/27315/diff/1/?file=736571#file736571line522> > > > > nextDuration/durationNext would be a more descriptive variable name. i'll leave it as is for consistency with the naming in slave. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27315/#review58951 ----------------------------------------------------------- On Oct. 28, 2014, 11:08 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27315/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2014, 11:08 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1903 > https://issues.apache.org/jira/browse/MESOS-1903 > > > Repository: mesos-git > > > Description > ------- > > Uses the same backoff (except no initial backoff) strategy used by the slave > during registration. > > > Diffs > ----- > > include/mesos/scheduler.hpp 42e4e279d059801cd85955fd04995b60051a2b5e > src/Makefile.am 374f284e1ac839fbcd8a28171b1ff4fbe8a17bd4 > src/local/constants.hpp PRE-CREATION > src/local/constants.cpp PRE-CREATION > src/local/flags.hpp 54e88319afc68007ff5d7c0d0179b685ef845c87 > src/sched/sched.cpp 0fb8c7bda75545389f8024489b3c76ae115111f4 > src/tests/fault_tolerance_tests.cpp > a18a41a3e34ff112e04e693447d757403e5013bd > > Diff: https://reviews.apache.org/r/27315/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
