----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27453/#review59562 -----------------------------------------------------------
docs/modules.md <https://reviews.apache.org/r/27453/#comment100830> explain "graced" docs/modules.md <https://reviews.apache.org/r/27453/#comment100831> Module => Modules docs/modules.md <https://reviews.apache.org/r/27453/#comment100832> remove "a" docs/modules.md <https://reviews.apache.org/r/27453/#comment100833> ... algorithms <insert:> written in scripting languages docs/modules.md <https://reviews.apache.org/r/27453/#comment100834> indentation docs/modules.md <https://reviews.apache.org/r/27453/#comment100835> This means that inline JSON and file JSON are not the same. Then we might as well not have inline JSON at all. How about this instead? ... --modules='{"libraries":[{"file":"/path/to/libfoo.so", "modules":[{"name":"org_apache_mesos_bar"}]}]}' ... docs/modules.md <https://reviews.apache.org/r/27453/#comment100836> Why are backquotes used here? docs/modules.md <https://reviews.apache.org/r/27453/#comment100837> foo => "foo" docs/modules.md <https://reviews.apache.org/r/27453/#comment100838> You could also write "What kinds of modules are supported?" Just a suggestion. docs/modules.md <https://reviews.apache.org/r/27453/#comment100839> support => only provides docs/modules.md <https://reviews.apache.org/r/27453/#comment100840> Additional graced modules will be added in the near future docs/modules.md <https://reviews.apache.org/r/27453/#comment100841> The ... docs/modules.md <https://reviews.apache.org/r/27453/#comment100842> The ... docs/modules.md <https://reviews.apache.org/r/27453/#comment100843> modules => module docs/modules.md <https://reviews.apache.org/r/27453/#comment100844> Add a recommendation to not simply use the kind name as module name. Different modules from the same org still need different names. docs/modules.md <https://reviews.apache.org/r/27453/#comment100845> Role => Kind docs/modules.md <https://reviews.apache.org/r/27453/#comment100846> role => kind docs/modules.md <https://reviews.apache.org/r/27453/#comment100847> role => kind docs/modules.md <https://reviews.apache.org/r/27453/#comment100848> The => to docs/modules.md <https://reviews.apache.org/r/27453/#comment100850> Move the summary up front? docs/modules.md <https://reviews.apache.org/r/27453/#comment100849> Role => Kind - Bernd Mathiske On Oct. 31, 2014, 4:23 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27453/ > ----------------------------------------------------------- > > (Updated Oct. 31, 2014, 4:23 p.m.) > > > Review request for mesos, Bernd Mathiske, Niklas Nielsen, and Till Toenshoff. > > > Repository: mesos-git > > > Description > ------- > > With bits copied from > https://cwiki.apache.org/confluence/display/MESOS/Mesos+Modules+Developer+Guide. > > Here is the url for markdown view: > https://github.com/karya0/mesos/blob/modules/docs/modules.md > > > Diffs > ----- > > docs/home.md 416a52ed99dba5ba55af97a300ce428355edd199 > docs/modules.md PRE-CREATION > > Diff: https://reviews.apache.org/r/27453/diff/ > > > Testing > ------- > > > Thanks, > > Kapil Arya > >
