----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27453/#review59702 -----------------------------------------------------------
Ship it! Looks great. Just some minor nits here and there :) docs/home.md <https://reviews.apache.org/r/27453/#comment101007> master, slave and tests. ? docs/modules.md <https://reviews.apache.org/r/27453/#comment100999> Not sure this is needed. Mesos as a whole is work in progress. Maybe stating that this was the initial version would be cleaner. But I dont have a strong opinion on that. docs/modules.md <https://reviews.apache.org/r/27453/#comment101000> (and tests)? Also s/slace/slave/ docs/modules.md <https://reviews.apache.org/r/27453/#comment101001> "atleast" - not sure that word exists. :) docs/modules.md <https://reviews.apache.org/r/27453/#comment101002> Add a blank line. docs/modules.md <https://reviews.apache.org/r/27453/#comment101003> Even though our style demands two blank lines here, I think for the sake of this document we should leave as is. docs/modules.md <https://reviews.apache.org/r/27453/#comment101004> i.e."," - is that correct? docs/modules.md <https://reviews.apache.org/r/27453/#comment101005> ... module selected for isolation: ? docs/modules.md <https://reviews.apache.org/r/27453/#comment101006> src/module/manager.cpp docs/modules.md <https://reviews.apache.org/r/27453/#comment100997> This should be "libraries" docs/modules.md <https://reviews.apache.org/r/27453/#comment100998> This should be "parameters" - Till Toenshoff On Nov. 4, 2014, 12:51 a.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27453/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2014, 12:51 a.m.) > > > Review request for mesos, Bernd Mathiske, Niklas Nielsen, and Till Toenshoff. > > > Repository: mesos-git > > > Description > ------- > > With bits copied from > https://cwiki.apache.org/confluence/display/MESOS/Mesos+Modules+Developer+Guide. > > Here is the url for markdown view: > https://github.com/karya0/mesos/blob/modules/docs/modules.md > > > Diffs > ----- > > docs/home.md 416a52ed99dba5ba55af97a300ce428355edd199 > docs/modules.md PRE-CREATION > > Diff: https://reviews.apache.org/r/27453/diff/ > > > Testing > ------- > > > Thanks, > > Kapil Arya > >
