----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27483/#review59673 -----------------------------------------------------------
src/hdfs/hdfs.hpp <https://reviews.apache.org/r/27483/#comment100962> Doing a style clean first on this patch. Move { to newline. src/launcher/fetcher.cpp <https://reviews.apache.org/r/27483/#comment100963> space bewteen the first parenthesis: if (hdfs.available().isError()) src/launcher/fetcher.cpp <https://reviews.apache.org/r/27483/#comment100964> Ditto src/launcher/fetcher.cpp <https://reviews.apache.org/r/27483/#comment100965> Two spaces between functions src/launcher/fetcher.cpp <https://reviews.apache.org/r/27483/#comment100966> Two spaces bewteen functions src/launcher/fetcher.cpp <https://reviews.apache.org/r/27483/#comment100968> if (result.isSome()) { src/launcher/fetcher.cpp <https://reviews.apache.org/r/27483/#comment100967> Space between parenthesis and also between starting bracket You're still working on unit tests right? - Timothy Chen On Nov. 3, 2014, 11:09 p.m., Ankur Chauhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27483/ > ----------------------------------------------------------- > > (Updated Nov. 3, 2014, 11:09 p.m.) > > > Review request for mesos and Timothy St. Clair. > > > Bugs: MESOS-1711 > https://issues.apache.org/jira/browse/MESOS-1711 > > > Repository: mesos-git > > > Description > ------- > > Previously, the fetcher used a hardcoded list of schemes to determine what > URIs could be fetched by hadoop (if available). This is now changed such that > we first check if hadoop can fetch them for us and then we fallback to the > os::net and then a local copy method (same as it used to be). This allows > users to fetch artifacts from arbitrary filesystems as long as hadoop is > correctly configured (in core-site.xml). > > > Diffs > ----- > > src/hdfs/hdfs.hpp bbfeddef106c598d8379ced085ef0605c4b2f380 > src/launcher/fetcher.cpp 9323c28237010fa065ef34d74435c151ded530a8 > > Diff: https://reviews.apache.org/r/27483/diff/ > > > Testing > ------- > > make check > sudo bin/mesos-tests.sh --verbose > support/mesos-style.py > > > Thanks, > > Ankur Chauhan > >
