----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27483/#review59682 -----------------------------------------------------------
src/hdfs/hdfs.hpp <https://reviews.apache.org/r/27483/#comment100975> We use proper sentences for comments. s/check/Check/ s/code == 0/code == 0./ s/hadoop/`hadoop'/ src/launcher/fetcher.cpp <https://reviews.apache.org/r/27483/#comment100981> 2 blank lines between outer elements. src/launcher/fetcher.cpp <https://reviews.apache.org/r/27483/#comment100980> s/HDFS/HadoopClient/ src/launcher/fetcher.cpp <https://reviews.apache.org/r/27483/#comment100982> s/HDFS/Hadoop Client/ src/launcher/fetcher.cpp <https://reviews.apache.org/r/27483/#comment100983> thank you. src/launcher/fetcher.cpp <https://reviews.apache.org/r/27483/#comment100977> period at the end. src/launcher/fetcher.cpp <https://reviews.apache.org/r/27483/#comment100984> Why the fall through to HDFS here? src/launcher/fetcher.cpp <https://reviews.apache.org/r/27483/#comment100979> period at the end. src/launcher/fetcher.cpp <https://reviews.apache.org/r/27483/#comment100978> Seems weird to do this after hdfs fetch. Is HDFS local copy as fast as "cp" ? I would change the semantics as follows: ``` if (local) { return fetchWithLocalCopy(); } if (http* or ftp*) { return fetchWithNet(); } return fetchWithHadoopClient(); ``` - Vinod Kone On Nov. 4, 2014, 12:02 a.m., Ankur Chauhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27483/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2014, 12:02 a.m.) > > > Review request for mesos and Timothy St. Clair. > > > Bugs: MESOS-1711 > https://issues.apache.org/jira/browse/MESOS-1711 > > > Repository: mesos-git > > > Description > ------- > > Previously, the fetcher used a hardcoded list of schemes to determine what > URIs could be fetched by hadoop (if available). This is now changed such that > we first check if hadoop can fetch them for us and then we fallback to the > os::net and then a local copy method (same as it used to be). This allows > users to fetch artifacts from arbitrary filesystems as long as hadoop is > correctly configured (in core-site.xml). > > > Diffs > ----- > > src/hdfs/hdfs.hpp bbfeddef106c598d8379ced085ef0605c4b2f380 > src/launcher/fetcher.cpp 9323c28237010fa065ef34d74435c151ded530a8 > > Diff: https://reviews.apache.org/r/27483/diff/ > > > Testing > ------- > > make check > sudo bin/mesos-tests.sh --verbose > support/mesos-style.py > > > Thanks, > > Ankur Chauhan > >
