> On Nov. 5, 2014, 7:29 a.m., Timothy Chen wrote: > > src/tests/fetcher_tests.cpp, line 121 > > <https://reviews.apache.org/r/27483/diff/9/?file=750212#file750212line121> > > > > How does this test work with a bogus url? > > Ankur Chauhan wrote: > I used it because it was mentioned in > [RFC-2606](http://tools.ietf.org/html/rfc2606) and seemed like a reliable > resource. But then maybe reaching out into the internet is not the best thing > to do either but it correctly exercises the code path. > > ``` > $ curl http://www.example.com/index.html > <!doctype html> > <html> > <head> > <title>Example Domain</title> > > <meta charset="utf-8" /> > <meta http-equiv="Content-type" content="text/html; charset=utf-8" /> > <meta name="viewport" content="width=device-width, initial-scale=1" /> > <style type="text/css"> > body { > background-color: #f0f0f2; > margin: 0; > padding: 0; > font-family: "Open Sans", "Helvetica Neue", Helvetica, Arial, > sans-serif; > > } > div { > width: 600px; > margin: 5em auto; > padding: 50px; > background-color: #fff; > border-radius: 1em; > } > a:link, a:visited { > color: #38488f; > text-decoration: none; > } > @media (max-width: 700px) { > body { > background-color: #fff; > } > div { > width: auto; > margin: 0 auto; > border-radius: 0; > padding: 1em; > } > } > </style> > </head> > > <body> > <div> > <h1>Example Domain</h1> > <p>This domain is established to be used for illustrative examples in > documents. You may use this > domain in examples without prior coordination or asking for > permission.</p> > <p><a href="http://www.iana.org/domains/example";>More > information...</a></p> > </div> > </body> > </html> > ```
AFAIK, this would be the first test that require Internet access, which is unfortunate. 2 options: --> Setup a simple HTTP server that serves a file/string via an endpoint. See 3rdparty/libprocess/src/tests/http_tests.cpp for examples. --> Hit <libprocess ip>:<libprocess port>/help. You can get the libprocess ip and port by doing process::ip() and process::port(). I think that should give a valid response. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27483/#review59938 ----------------------------------------------------------- On Nov. 5, 2014, 6:39 a.m., Ankur Chauhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27483/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2014, 6:39 a.m.) > > > Review request for mesos, Timothy Chen, Timothy St. Clair, and Vinod Kone. > > > Bugs: MESOS-1711 > https://issues.apache.org/jira/browse/MESOS-1711 > > > Repository: mesos-git > > > Description > ------- > > Previously, the fetcher used a hardcoded list of schemes to determine what > URIs could be fetched by hadoop (if available). This is now changed such that > we first check if hadoop can fetch them for us and then we fallback to the > os::net and then a local copy method (same as it used to be). This allows > users to fetch artifacts from arbitrary filesystems as long as hadoop is > correctly configured (in core-site.xml). > > > Diffs > ----- > > src/hdfs/hdfs.hpp bbfeddef106c598d8379ced085ef0605c4b2f380 > src/launcher/fetcher.cpp 9323c28237010fa065ef34d74435c151ded530a8 > src/tests/fetcher_tests.cpp d7754009a59fedb43e3422c56b3a786ce80164aa > > Diff: https://reviews.apache.org/r/27483/diff/ > > > Testing > ------- > > make check > sudo bin/mesos-tests.sh --verbose > support/mesos-style.py > > > Thanks, > > Ankur Chauhan > >
