----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27483/#review60040 -----------------------------------------------------------
looking goood. minor fixes and i'll get this committed. src/launcher/fetcher.cpp <https://reviews.apache.org/r/27483/#comment101383> s/uri/URI/ src/launcher/fetcher.cpp <https://reviews.apache.org/r/27483/#comment101384> s/uri/URI/ src/launcher/fetcher.cpp <https://reviews.apache.org/r/27483/#comment101385> s/uris/URIs/ src/launcher/fetcher.cpp <https://reviews.apache.org/r/27483/#comment101390> fetcher is not supposed to be run manually by users. so i would kill this. src/launcher/fetcher.cpp <https://reviews.apache.org/r/27483/#comment101391> kill these and the usage(), printVersion() functions. src/tests/fetcher_tests.cpp <https://reviews.apache.org/r/27483/#comment101382> pull this down to where it is used (#99). src/tests/fetcher_tests.cpp <https://reviews.apache.org/r/27483/#comment101380> 2 blank lines. - Vinod Kone On Nov. 5, 2014, 9:24 p.m., Ankur Chauhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27483/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2014, 9:24 p.m.) > > > Review request for mesos, Timothy Chen, Timothy St. Clair, and Vinod Kone. > > > Bugs: MESOS-1711 > https://issues.apache.org/jira/browse/MESOS-1711 > > > Repository: mesos-git > > > Description > ------- > > Previously, the fetcher used a hardcoded list of schemes to determine what > URIs could be fetched by hadoop (if available). This is now changed such that > we first check if hadoop can fetch them for us and then we fallback to the > os::net and then a local copy method (same as it used to be). This allows > users to fetch artifacts from arbitrary filesystems as long as hadoop is > correctly configured (in core-site.xml). > > > Diffs > ----- > > src/hdfs/hdfs.hpp bbfeddef106c598d8379ced085ef0605c4b2f380 > src/launcher/fetcher.cpp 9323c28237010fa065ef34d74435c151ded530a8 > src/tests/fetcher_tests.cpp d7754009a59fedb43e3422c56b3a786ce80164aa > > Diff: https://reviews.apache.org/r/27483/diff/ > > > Testing > ------- > > make check > sudo bin/mesos-tests.sh --verbose > support/mesos-style.py > > > Thanks, > > Ankur Chauhan > >
