-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27516/
-----------------------------------------------------------
(Updated Nov. 6, 2014, 6:59 a.m.)
Review request for mesos and Benjamin Hindman.
Changes
-------
Added missing files.
Bugs: MESOS-1316
https://issues.apache.org/jira/browse/MESOS-1316
Repository: mesos-git
Description
-------
Manually rebasing and re-editing https://reviews.apache.org/r/21233/, which is
supposed to be replaced now by this patch.
Original description: "To test the mesos-fetcher (and the setting of the
environment) more cleanly I did some refactoring into a 'fetcher' namespace."
Also moved fetcher environment tests to fetcher test file. Added two fetcher
tests.
Diffs (updated)
-----
src/Makefile.am 9ab3b9c05d435d18ed1c2966f695857fa205e9fd
src/launcher/fetcher.cpp bd95928bc3191970330e839bcf41e343d5142c54
src/slave/containerizer/containerizer.hpp
8a6641269b8e010a708aa8b05bb65e2e72501625
src/slave/containerizer/containerizer.cpp
0254679508167a390fd6fed855f19794354ac081
src/slave/containerizer/docker.cpp a6689203adbdcb0ad12583389eaeb83329e4ef6b
src/slave/containerizer/fetcher.hpp PRE-CREATION
src/slave/containerizer/fetcher.cpp PRE-CREATION
src/slave/containerizer/mesos/containerizer.hpp
ab3bb6ffed28e76820020d8fc457f70d948e6657
src/slave/containerizer/mesos/containerizer.cpp
4bd266552fcd28b0dcbc323bfd6a4043bbd835a9
src/tests/containerizer_tests.cpp 2c90d2fc18a3268c55b6dfe98699bfb36d093983
src/tests/fetcher_tests.cpp e026e875c7197cd214ef0432d7c40207553c8671
Diff: https://reviews.apache.org/r/27516/diff/
Testing
-------
make check on Mac OS 10.10 and Ubuntu 14.4.
In total, 3 tests fail: ExamplesTest.NoExecutorFramework,
ExamplesTest.JavaFramework
, ExamplesTest.PythonFramework. It is strongly suspected that those are
unrelated to this code change and just generally flaky.
Thanks,
Bernd Mathiske