> On Nov. 6, 2014, 4:44 a.m., Benjamin Hindman wrote: > > src/slave/containerizer/fetcher.hpp, line 64 > > <https://reviews.apache.org/r/27516/diff/3/?file=747421#file747421line64> > > > > Mind replacing '> >' with '>>' everywhere in your patch please? Thanks! > > Bernd Mathiske wrote: > So we are now only using C++ compilers that do not have this bug any > more? Nice! (Only about 12000 other places in Mesos to fix then :-)
Yup, pretty nice huh! Also, when I said "everywhere in your patch", I just meant the code you're actually changing, not all code in each file you changed. ;-) Not a huge deal, but definitely more disruptive for the reviewer. > On Nov. 6, 2014, 4:44 a.m., Benjamin Hindman wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 524 > > <https://reviews.apache.org/r/27516/diff/3/?file=747423#file747423line524> > > > > Why does this need to be a Future? It looks like you're chaining this > > below via a 'then', which means you can just use Option<int> since a 'then' > > only invokes this if the Future is ready. The fact that you're always doing > > a 'get()' on the future too implies this precondition. > > Bernd Mathiske wrote: > If we made it a plain Option<int> then that value would have to be > present at the time fetcher::run() returns. This would mean we have to block > in fetcher::run() to wait for the fetcher. No, since you're doing a '.then(...)' with a lambda::_1 then you know that the Future is ready and you can invoke a function with the Future unpacked. I made this change for you, no worries. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27516/#review60098 ----------------------------------------------------------- On Nov. 6, 2014, 2:59 p.m., Bernd Mathiske wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27516/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2014, 2:59 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-1316 > https://issues.apache.org/jira/browse/MESOS-1316 > > > Repository: mesos-git > > > Description > ------- > > Manually rebasing and re-editing https://reviews.apache.org/r/21233/, which > is supposed to be replaced now by this patch. > > Original description: "To test the mesos-fetcher (and the setting of the > environment) more cleanly I did some refactoring into a 'fetcher' namespace." > > Also moved fetcher environment tests to fetcher test file. Added two fetcher > tests. > > > Diffs > ----- > > src/Makefile.am 9ab3b9c05d435d18ed1c2966f695857fa205e9fd > src/launcher/fetcher.cpp bd95928bc3191970330e839bcf41e343d5142c54 > src/slave/containerizer/containerizer.hpp > 8a6641269b8e010a708aa8b05bb65e2e72501625 > src/slave/containerizer/containerizer.cpp > 0254679508167a390fd6fed855f19794354ac081 > src/slave/containerizer/docker.cpp a6689203adbdcb0ad12583389eaeb83329e4ef6b > src/slave/containerizer/fetcher.hpp PRE-CREATION > src/slave/containerizer/fetcher.cpp PRE-CREATION > src/slave/containerizer/mesos/containerizer.hpp > ab3bb6ffed28e76820020d8fc457f70d948e6657 > src/slave/containerizer/mesos/containerizer.cpp > 4bd266552fcd28b0dcbc323bfd6a4043bbd835a9 > src/tests/containerizer_tests.cpp 2c90d2fc18a3268c55b6dfe98699bfb36d093983 > src/tests/fetcher_tests.cpp e026e875c7197cd214ef0432d7c40207553c8671 > > Diff: https://reviews.apache.org/r/27516/diff/ > > > Testing > ------- > > make check on Mac OS 10.10 and Ubuntu 14.4. > > In total, 3 tests fail: ExamplesTest.NoExecutorFramework, > ExamplesTest.JavaFramework > , ExamplesTest.PythonFramework. It is strongly suspected that those are > unrelated to this code change and just generally flaky. > > > Thanks, > > Bernd Mathiske > >
