> On Nov. 11, 2014, 8:49 p.m., Vinod Kone wrote: > > src/messages/messages.proto, line 375 > > <https://reviews.apache.org/r/27494/diff/5/?file=756747#file756747line375> > > > > from your description i'm assuming this is backwards compatible? if > > master or slave use different versions (old or new) of this protobuf, > > things will work? did you test this?
Yes, that is backwards compatible, please see https://www.mail-archive.com/protobuf@googlegroups.com/msg01478.html -- TLDR; on the wire, they are identical. ...and yes, I tested that, added a note to my "testing" blob pointing that out. Thanks for this comment, I think putting extra care on the compatibility is always a good thing. - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27494/#review60846 ----------------------------------------------------------- On Nov. 10, 2014, 2:24 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27494/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2014, 2:24 p.m.) > > > Review request for mesos, Adam B and Vinod Kone. > > > Bugs: MESOS-2040 > https://issues.apache.org/jira/browse/MESOS-2040 > > > Repository: mesos-git > > > Description > ------- > > Also fixes messages.proto to use a raw bytestream instead of a string for > AuthenticationStartMessage as non CRAM-MD5 authentication may transmit binary > data. > Note that the change of AuthenticationStartMessage does basically have no > impact on C++ based proto code other than the prevention of a warning due to > non-UTF8 characters being encoded. That does in fact occur when using non > CRAM-MD5 based SASL authentication mechanisms. > > Note that this patch covers modularized slave authentication only. Framework > authentication is currently covered by the default (built-in) implementation. > There will be a subsequent patch for modularized framework authentication. > > > Diffs > ----- > > src/messages/messages.proto de0e2a2 > src/sched/sched.cpp 8ca0526 > src/scheduler/scheduler.cpp c74187c > src/slave/constants.hpp 701dd89 > src/slave/constants.cpp d6ad78c > src/slave/flags.hpp efbd35d > src/slave/slave.hpp 72bbec9 > src/slave/slave.cpp 81e0c4b > > Diff: https://reviews.apache.org/r/27494/diff/ > > > Testing > ------- > > make check > > NOTE all three CRAM-MD5 authenticatee module related RRs need to get applied > before running make check. > > > Thanks, > > Till Toenshoff > >
