-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27494/
-----------------------------------------------------------
(Updated Nov. 12, 2014, 2:48 p.m.)
Review request for mesos, Adam B and Vinod Kone.
Bugs: MESOS-2040
https://issues.apache.org/jira/browse/MESOS-2040
Repository: mesos-git
Description
-------
Also fixes messages.proto to use a raw bytestream instead of a string for
AuthenticationStartMessage as non CRAM-MD5 authentication may transmit binary
data.
Note that the change of AuthenticationStartMessage does basically have no
impact on C++ based proto code other than the prevention of a warning due to
non-UTF8 characters being encoded. That does in fact occur when using non
CRAM-MD5 based SASL authentication mechanisms.
Note that this patch covers modularized slave authentication only. Framework
authentication is currently covered by the default (built-in) implementation.
There will be a subsequent patch for modularized framework authentication.
Diffs
-----
src/messages/messages.proto de0e2a2
src/sched/sched.cpp 8ca0526
src/scheduler/scheduler.cpp c74187c
src/slave/constants.hpp 701dd89
src/slave/constants.cpp d6ad78c
src/slave/flags.hpp efbd35d
src/slave/slave.hpp d9f9d2e
src/slave/slave.cpp ba00bf5
Diff: https://reviews.apache.org/r/27494/diff/
Testing
-------
make check
Also tested messages.proto change for backwards compatibility by running an
unaltered master against a slave relying on this change and the other way
around.
NOTE all three CRAM-MD5 authenticatee module related RRs need to get applied
before running make check.
Thanks,
Till Toenshoff
