----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27865/#review61005 -----------------------------------------------------------
3rdparty/libprocess/src/encoder.hpp <https://reviews.apache.org/r/27865/#comment102462> Have you run mesos-style.py? Looks like this line exceeds 80 columns. We tend to stick pointer * and reference & to the type, to is becomes (in_addr*) More high-level comment: try to take a look at https://github.com/apache/mesos/blob/master/3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp#L312 You should be able to use the IP class alongside the << operator overload - Niklas Nielsen On Nov. 12, 2014, 5:53 a.m., Dario Rexin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27865/ > ----------------------------------------------------------- > > (Updated Nov. 12, 2014, 5:53 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-2071 > https://issues.apache.org/jira/browse/MESOS-2071 > > > Repository: mesos-git > > > Description > ------- > > While working on a pure Scala driver for Mesos, I discovered that libprocess > does not generate valid HTTP. It uses chunked encoding combined with HTTP > 1.0, which has only been added in HTTP 1.1. Additionally it stores the PID in > the User-Agent field with an incompatibe format ('@' and ':' are not > allowed). This patch sets the HTTP version to 1.1, adds an empty Host header > (Host is mandatory in 1.1) and adds 3 new fields: X-Mesos-Id, X-Mesos-Ip, > X-Mesos-Port containing the PID parts. The User-Agent header is left > untouched for backwards compatibility reasons. Even strict HTTP parser > shouldn't error, but just ignore everything between the invalid character and > the CRLF. > > > Diffs > ----- > > 3rdparty/libprocess/src/encoder.hpp 9c5aa81 > 3rdparty/libprocess/src/tests/process_tests.cpp b985fb7 > > Diff: https://reviews.apache.org/r/27865/diff/ > > > Testing > ------- > > - ran `make check` on Linux and OSX > - setup a cluster consisting of 1 Master, 1 Slave and 1 Marathon instance, > deployed a couple of tasks and destroyed them afterwards > > > Thanks, > > Dario Rexin > >
