----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27865/#review62336 -----------------------------------------------------------
Bad patch! Reviews applied: [27865] Failed command: ./support/apply-review.sh -n -r 27865 Error: 2014-11-20 08:06:16 URL:https://reviews.apache.org/r/27865/diff/raw/ [2260/2260] -> "27865.patch" [1] error: patch failed: 3rdparty/libprocess/src/pid.cpp:64 error: 3rdparty/libprocess/src/pid.cpp: patch does not apply Failed to apply patch - Mesos ReviewBot On Nov. 20, 2014, 1:01 a.m., Dario Rexin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27865/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2014, 1:01 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-2071 > https://issues.apache.org/jira/browse/MESOS-2071 > > > Repository: mesos-git > > > Description > ------- > > While working on a pure Scala driver for Mesos, I discovered that libprocess > does not generate valid HTTP. It uses chunked encoding combined with HTTP > 1.0, which has only been added in HTTP 1.1. Additionally it stores the PID in > the User-Agent field with an incompatibe format ('@' and ':' are not > allowed). This patch sets the HTTP version to 1.1, adds an empty Host header > (Host is mandatory in 1.1) and adds 3 new fields: X-Mesos-Id, X-Mesos-Ip, > X-Mesos-Port containing the PID parts. The User-Agent header is left > untouched for backwards compatibility reasons. Even strict HTTP parser > shouldn't error, but just ignore everything between the invalid character and > the CRLF. > > > Diffs > ----- > > 3rdparty/libprocess/src/encoder.hpp 9c5aa81 > 3rdparty/libprocess/src/pid.cpp 20ff25c > 3rdparty/libprocess/src/tests/process_tests.cpp b985fb7 > > Diff: https://reviews.apache.org/r/27865/diff/ > > > Testing > ------- > > - ran `make check` on Linux and OSX > - setup a cluster consisting of 1 Master, 1 Slave and 1 Marathon instance, > deployed a couple of tasks and destroyed them afterwards > > > Thanks, > > Dario Rexin > >