> On Nov. 13, 2014, 1:25 a.m., Adam B wrote: > > LGTM. I can fix the spacing before committing.
Yes please. I did actually try to follow other examples but didn't check properly enough (obviously) as my checks never really turned up a non trivial forward declaring example. I now looked at process/future.hpp and that one does exactly what you ask for; double-blanks for anything that does possibly contain inner elements (which includes namespaces). We should have an automated rule to prevent me falling into this trap again :) - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27619/#review61161 ----------------------------------------------------------- On Nov. 12, 2014, 10:09 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27619/ > ----------------------------------------------------------- > > (Updated Nov. 12, 2014, 10:09 p.m.) > > > Review request for mesos, Adam B, Kapil Arya, and Vinod Kone. > > > Bugs: MESOS-1894 > https://issues.apache.org/jira/browse/MESOS-1894 > > > Repository: mesos-git > > > Description > ------- > > see summary. > > > Diffs > ----- > > src/authentication/cram_md5/authenticator.hpp a23bf5d > src/tests/cram_md5_authentication_tests.cpp f91f1f9 > src/tests/module.hpp 7970c28 > src/tests/module.cpp 482ed22 > > Diff: https://reviews.apache.org/r/27619/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Till Toenshoff > >
