> On Nov. 18, 2014, 3:10 p.m., Dominic Hamon wrote: > > 3rdparty/libprocess/src/libev.hpp, line 38 > > <https://reviews.apache.org/r/28184/diff/2/?file=767746#file767746line38> > > > > double underscores in names are reserved. > > Joris Van Remoortere wrote: > I am using the pattern for thread local storage from process.hpp L396 and > exectuor.hpp L263. Is this not correct?
it's consistent. it's not correct (as per the C++ standard). we'll get there one day. - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28184/#review62045 ----------------------------------------------------------- On Nov. 18, 2014, 1:11 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28184/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2014, 1:11 p.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Bugs: MESOS-2125 > https://issues.apache.org/jira/browse/MESOS-2125 > > > Repository: mesos-git > > > Description > ------- > > This improves performance by short-circuiting run_in_event_loop to just call > the lambda if it is already in the event loop. > > > Diffs > ----- > > 3rdparty/libprocess/src/libev.hpp 04847e30b0d764d258b8c0971da87180043161f2 > 3rdparty/libprocess/src/process.cpp > 404a32dae1b3d22cb55dcbd084623d6b0cb82c71 > > Diff: https://reviews.apache.org/r/28184/diff/ > > > Testing > ------- > > make check > 3rdparty/libprocess/benchmark improved throughput ~27% > > > Thanks, > > Joris Van Remoortere > >
