----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28717/#review64150 -----------------------------------------------------------
Great work Evelina! Just some minor code quality items below, could you or Dominic follow up with the fixes? Thank you! :) 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp <https://reviews.apache.org/r/28717/#comment106597> Let's call this "result" :) 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp <https://reviews.apache.org/r/28717/#comment106599> In general we avoid abbreviated names like "hints", and "results", which are _informative_ as to what they represent. :) 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp <https://reviews.apache.org/r/28717/#comment106598> Ditto here. - Ben Mahler On Dec. 5, 2014, 9:26 p.m., Evelina Dumitrescu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28717/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2014, 9:26 p.m.) > > > Review request for mesos and Dominic Hamon. > > > Bugs: MESOS-2178 > https://issues.apache.org/jira/browse/MESOS-2178 > > > Repository: mesos-git > > > Description > ------- > > Replaced obsolete functions gethostbyname2_r and gethostbyname2 with > getaddrinfo and introduced getIP. > Created initialization wrappers for sockaddr_in and addrinfo > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp > a992bd9f7caf3abcc2c5e14519ca7e3ac045bb4b > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > ec259cdee876c64f3e562aa77d4d52e964a173ab > > Diff: https://reviews.apache.org/r/28717/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Evelina Dumitrescu > >
