> On Dec. 6, 2014, 2:04 a.m., Ben Mahler wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 147 > > <https://reviews.apache.org/r/28717/diff/3/?file=784041#file784041line147> > > > > Let's call this "result" :)
This convention is used everywhere in the code :) > On Dec. 6, 2014, 2:04 a.m., Ben Mahler wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 187 > > <https://reviews.apache.org/r/28717/diff/3/?file=784041#file784041line187> > > > > In general we avoid abbreviated names like "hints", and "results", > > which are _informative_ as to what they represent. :) Can you rephrase this, I don't understand what you mean :). I used the same convention as previously: struct hostent he, *hep; -> struct addrinfo ai, *aip; - Evelina ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28717/#review64150 ----------------------------------------------------------- On Dec. 5, 2014, 9:26 p.m., Evelina Dumitrescu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28717/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2014, 9:26 p.m.) > > > Review request for mesos and Dominic Hamon. > > > Bugs: MESOS-2178 > https://issues.apache.org/jira/browse/MESOS-2178 > > > Repository: mesos-git > > > Description > ------- > > Replaced obsolete functions gethostbyname2_r and gethostbyname2 with > getaddrinfo and introduced getIP. > Created initialization wrappers for sockaddr_in and addrinfo > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp > a992bd9f7caf3abcc2c5e14519ca7e3ac045bb4b > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > ec259cdee876c64f3e562aa77d4d52e964a173ab > > Diff: https://reviews.apache.org/r/28717/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Evelina Dumitrescu > >
