> On Jan. 6, 2015, 6:06 p.m., Timothy Chen wrote: > > include/mesos/mesos.proto, line 1023 > > <https://reviews.apache.org/r/29600/diff/1/?file=807137#file807137line1023> > > > > I think this can be confusing pushing this into the top level, as it > > becomes unclear what this is used for especially with a very generic name > > with Task. > > > > What do you think about wrapping these with a internal namespace, so at > > least it's clear it's not intended as a public API.
Added a comment on top. - Kapil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29600/#review66940 ----------------------------------------------------------- On Jan. 9, 2015, 5:53 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29600/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2015, 5:53 p.m.) > > > Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen. > > > Bugs: MESOS-2096 > https://issues.apache.org/jira/browse/MESOS-2096 > > > Repository: mesos-git > > > Description > ------- > > [2/10] Build Mesos Modules outside Mesos source tree. > > This prepares us to expose src/slave/containerizer/isolator.hpp as > <mesos/slave/isolator.hpp> and src/slave/state.hpp as <mesos/slave/state.hpp> > for inclusion for Isolator modules. > > > Diffs > ----- > > include/mesos/mesos.proto 540071db64961466eb75c779b3ea6863f4594437 > src/common/http.hpp afce7fea334c7bfa57efc48c413bf906a2ebde32 > src/common/type_utils.hpp 2d22db85f87ec5c1134208aae5b2105d2d267000 > src/common/type_utils.cpp fcc9eb0e27a9cbf53f7923f0c051a6578527ec37 > src/messages/messages.proto 16043dd934cbfc1159dad7adf366dfbfcc5a077b > src/slave/state.hpp 592182b21ae2700c627f180db38ca5dc1b3c9e8a > > Diff: https://reviews.apache.org/r/29600/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Kapil Arya > >
