----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29600/#review67898 -----------------------------------------------------------
include/mesos/mesos.proto <https://reviews.apache.org/r/29600/#comment111988> Just use "/*" style for all comments including TODOs. include/mesos/mesos.proto <https://reviews.apache.org/r/29600/#comment111990> There is no include/mesos/state.hpp afaict. Did you mean src/slave/state.hpp? Also, it is not clear why state.hpp depending on this proto means this should be moved from internal to public namespace. include/mesos/mesos.proto <https://reviews.apache.org/r/29600/#comment111989> ditto. use "/*" style. include/mesos/mesos.proto <https://reviews.apache.org/r/29600/#comment111991> ditto. - Vinod Kone On Jan. 13, 2015, 4:42 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29600/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2015, 4:42 p.m.) > > > Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen. > > > Bugs: MESOS-2096 > https://issues.apache.org/jira/browse/MESOS-2096 > > > Repository: mesos-git > > > Description > ------- > > [2/10] Build Mesos Modules outside Mesos source tree. > > This prepares us to expose src/slave/containerizer/isolator.hpp as > <mesos/slave/isolator.hpp> and src/slave/state.hpp as <mesos/slave/state.hpp> > for inclusion for Isolator modules. > > > Diffs > ----- > > include/mesos/mesos.proto 5007c0c58c5573ef19163c2c58cc3a7c5b555f46 > src/common/http.hpp afce7fea334c7bfa57efc48c413bf906a2ebde32 > src/common/type_utils.hpp 2d22db85f87ec5c1134208aae5b2105d2d267000 > src/common/type_utils.cpp fcc9eb0e27a9cbf53f7923f0c051a6578527ec37 > src/messages/messages.proto 5bd075e9bfe17be334294b5e4c573eb0233030be > src/slave/state.hpp 70777cf6ab681c29ca4df601fe47903e1dbdf41f > > Diff: https://reviews.apache.org/r/29600/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Kapil Arya > >
