> On Jan. 14, 2015, 1:09 a.m., Jie Yu wrote: > > src/tests/port_mapping_tests.cpp, lines 1631-1632 > > <https://reviews.apache.org/r/29033/diff/5/?file=813956#file813956line1631> > > > > Is it guaranteed that the connective will be still active? If not, I > > would rather not introduce those checks as it could cause flackyness.
I want to keep these tests because they gurantee that I have done the control structure based on flags right in `PortMappingStatistics::execute`. `PortMappingIsolator::__usage` could then be simplied to merely retriving all the results. Having these checks here gives more faith there. As for the performance, there is only one test connection here so both 'summary' and 'details' should return in no time. - Chi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29033/#review67989 ----------------------------------------------------------- On Jan. 14, 2015, 2:06 a.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29033/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2015, 2:06 a.m.) > > > Review request for mesos, Dominic Hamon, Ian Downes, Jie Yu, and Cong Wang. > > > Repository: mesos-git > > > Description > ------- > > While we are still working to make RTT less expensive to get, expose total > number of tcp connections in use and in TIME_WAIT. > > > Diffs > ----- > > include/mesos/mesos.proto 5007c0c > src/slave/containerizer/isolators/network/port_mapping.hpp f1e2352 > src/slave/containerizer/isolators/network/port_mapping.cpp 2d81336 > src/slave/flags.hpp f1b8dfb > src/tests/port_mapping_tests.cpp d57d3e6 > > Diff: https://reviews.apache.org/r/29033/diff/ > > > Testing > ------- > > expanded a test case to test PortMappingStatistics. > > > Thanks, > > Chi Zhang > >
