> On Jan. 20, 2015, 9:01 p.m., Dominic Hamon wrote: > > src/slave/containerizer/isolators/network/port_mapping.cpp, line 570 > > <https://reviews.apache.org/r/29033/diff/7/?file=827141#file827141line570> > > > > nit: the pattern throughout is cerr/continue. why not do the same here > > and lose the else: > > > > if (inuse.isError()) { > > cerr << "..."; > > continue; > > } > > object.values["..."] = inuse.get();
Good catch. I've corrected it in the commit. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29033/#review68780 ----------------------------------------------------------- On Jan. 20, 2015, 8:21 p.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29033/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2015, 8:21 p.m.) > > > Review request for mesos, Dominic Hamon, Ian Downes, Jie Yu, and Cong Wang. > > > Repository: mesos-git > > > Description > ------- > > While we are still working to make RTT less expensive to get, expose total > number of tcp connections in use and in TIME_WAIT. > > > Diffs > ----- > > include/mesos/mesos.proto 859aa2f > src/slave/containerizer/isolators/network/port_mapping.hpp f1e2352 > src/slave/containerizer/isolators/network/port_mapping.cpp 2d81336 > src/slave/flags.hpp 33a0cb6 > src/tests/port_mapping_tests.cpp d57d3e6 > > Diff: https://reviews.apache.org/r/29033/diff/ > > > Testing > ------- > > expanded a test case to test PortMappingStatistics. > > > Thanks, > > Chi Zhang > >
