> On Jan. 14, 2015, 6:09 p.m., Adam B wrote: > > Were you able to reproduce the issue without your changes and prove that it > > was fixed with your changes, or are you guessing here? > > Adam B wrote: > Pasting in Till's summary of the problem: > "After some investigation, it turns out that my two-fold solution had a > serious flaw — it all stems from the way CyrusSASL works — in the end, my > code re-adds the aux-prop-plugin for every new instance of the master > (libprocess-)process. > CyrusSASL does bind its context to the os-process (transparently). So > when the tests keep using the same os-process (which they certainly do), my > patch keeps adding more (identical) plugins. All those plugins remain active > and at some point this will trigger delays big enough to break slow machines > (e.g. travis-ci)."
Well I did definitely fix the following... Log before this very patch Test 1: ``` I0114 15:50:03.058748 283148288 authenticatee.hpp:275] Received SASL authentication step I0114 15:50:03.058814 285294592 authenticator.hpp:263] Received SASL authentication step I0114 15:50:03.058832 285294592 auxprop.cpp:99] Request to lookup properties for user: 'benh' realm: 'lobomacpro2.fritz.box' server FQDN: 'lobomacpro2.fritz.box' SASL_AUXPROP_VERIFY_AGAINST_HASH: false SASL_AUXPROP_OVE RRIDE: false SASL_AUXPROP_AUTHZID: false I0114 15:50:03.058848 285294592 auxprop.cpp:171] Looking up auxiliary property '*userPassword' I0114 15:50:03.058871 285294592 auxprop.cpp:171] Looking up auxiliary property '*cmusaslsecretCRAM-MD5' I0114 15:50:03.058881 285294592 auxprop.cpp:99] Request to lookup properties for user: 'benh' realm: 'lobomacpro2.fritz.box' server FQDN: 'lobomacpro2.fritz.box' SASL_AUXPROP_VERIFY_AGAINST_HASH: false SASL_AUXPROP_OVE RRIDE: false SASL_AUXPROP_AUTHZID: true I0114 15:50:03.058888 285294592 auxprop.cpp:121] Skipping auxiliary property '*userPassword' since SASL_AUXPROP_AUTHZID == true I0114 15:50:03.058893 285294592 auxprop.cpp:121] Skipping auxiliary property '*cmusaslsecretCRAM-MD5' since SASL_AUXPROP_AUTHZID == true ``` Test 2: ``` I0114 15:50:03.061559 283684864 authenticatee.hpp:275] Received SASL authentication step I0114 15:50:03.061652 282611712 authenticator.hpp:263] Received SASL authentication step I0114 15:50:03.061669 282611712 auxprop.cpp:99] Request to lookup properties for user: 'benh' realm: 'lobomacpro2.fritz.box' server FQDN: 'lobomacpro2.fritz.box' SASL_AUXPROP_VERIFY_AGAINST_HASH: false SASL_AUXPROP_OVE RRIDE: false SASL_AUXPROP_AUTHZID: false I0114 15:50:03.061678 282611712 auxprop.cpp:171] Looking up auxiliary property '*userPassword' I0114 15:50:03.061691 282611712 auxprop.cpp:171] Looking up auxiliary property '*cmusaslsecretCRAM-MD5' I0114 15:50:03.061699 282611712 auxprop.cpp:99] Request to lookup properties for user: 'benh' realm: 'lobomacpro2.fritz.box' server FQDN: 'lobomacpro2.fritz.box' SASL_AUXPROP_VERIFY_AGAINST_HASH: false SASL_AUXPROP_OVE RRIDE: false SASL_AUXPROP_AUTHZID: false I0114 15:50:03.061707 282611712 auxprop.cpp:153] Skipping auxiliary property 'userPassword' since SASL_AUXPROP_OVERRIDE == false and value(s) already set I0114 15:50:03.061712 282611712 auxprop.cpp:171] Looking up auxiliary property '*cmusaslsecretCRAM-MD5' I0114 15:50:03.061720 282611712 auxprop.cpp:99] Request to lookup properties for user: 'benh' realm: 'lobomacpro2.fritz.box' server FQDN: 'lobomacpro2.fritz.box' SASL_AUXPROP_VERIFY_AGAINST_HASH: false SASL_AUXPROP_OVE RRIDE: false SASL_AUXPROP_AUTHZID: true I0114 15:50:03.061727 282611712 auxprop.cpp:121] Skipping auxiliary property '*userPassword' since SASL_AUXPROP_AUTHZID == true I0114 15:50:03.061732 282611712 auxprop.cpp:121] Skipping auxiliary property '*cmusaslsecretCRAM-MD5' since SASL_AUXPROP_AUTHZID == true I0114 15:50:03.061736 282611712 auxprop.cpp:99] Request to lookup properties for user: 'benh' realm: 'lobomacpro2.fritz.box' server FQDN: 'lobomacpro2.fritz.box' SASL_AUXPROP_VERIFY_AGAINST_HASH: false SASL_AUXPROP_OVE RRIDE: false SASL_AUXPROP_AUTHZID: true I0114 15:50:03.062016 282611712 auxprop.cpp:121] Skipping auxiliary property '*userPassword' since SASL_AUXPROP_AUTHZID == true I0114 15:50:03.062022 282611712 auxprop.cpp:121] Skipping auxiliary property '*cmusaslsecretCRAM-MD5' since SASL_AUXPROP_AUTHZID == true ``` Test 3: ``` I0114 15:50:03.064009 284758016 authenticatee.hpp:275] Received SASL authentication step I0114 15:50:03.064116 284221440 authenticator.hpp:263] Received SASL authentication step I0114 15:50:03.064136 284221440 auxprop.cpp:99] Request to lookup properties for user: 'benh' realm: 'lobomacpro2.fritz.box' server FQDN: 'lobomacpro2.fritz.box' SASL_AUXPROP_VERIFY_AGAINST_HASH: false SASL_AUXPROP_OVE RRIDE: false SASL_AUXPROP_AUTHZID: false I0114 15:50:03.064148 284221440 auxprop.cpp:171] Looking up auxiliary property '*userPassword' I0114 15:50:03.064157 284221440 auxprop.cpp:171] Looking up auxiliary property '*cmusaslsecretCRAM-MD5' I0114 15:50:03.064165 284221440 auxprop.cpp:99] Request to lookup properties for user: 'benh' realm: 'lobomacpro2.fritz.box' server FQDN: 'lobomacpro2.fritz.box' SASL_AUXPROP_VERIFY_AGAINST_HASH: false SASL_AUXPROP_OVE RRIDE: false SASL_AUXPROP_AUTHZID: false I0114 15:50:03.064172 284221440 auxprop.cpp:171] Looking up auxiliary property '*userPassword' I0114 15:50:03.064177 284221440 auxprop.cpp:171] Looking up auxiliary property '*cmusaslsecretCRAM-MD5' I0114 15:50:03.064182 284221440 auxprop.cpp:99] Request to lookup properties for user: 'benh' realm: 'lobomacpro2.fritz.box' server FQDN: 'lobomacpro2.fritz.box' SASL_AUXPROP_VERIFY_AGAINST_HASH: false SASL_AUXPROP_OVE RRIDE: false SASL_AUXPROP_AUTHZID: false I0114 15:50:03.064188 284221440 auxprop.cpp:171] Looking up auxiliary property '*userPassword' I0114 15:50:03.064191 284221440 auxprop.cpp:171] Looking up auxiliary property '*cmusaslsecretCRAM-MD5' I0114 15:50:03.064196 284221440 auxprop.cpp:99] Request to lookup properties for user: 'benh' realm: 'lobomacpro2.fritz.box' server FQDN: 'lobomacpro2.fritz.box' SASL_AUXPROP_VERIFY_AGAINST_HASH: false SASL_AUXPROP_OVE RRIDE: false SASL_AUXPROP_AUTHZID: true I0114 15:50:03.064267 284221440 auxprop.cpp:121] Skipping auxiliary property '*userPassword' since SASL_AUXPROP_AUTHZID == true I0114 15:50:03.064278 284221440 auxprop.cpp:121] Skipping auxiliary property '*cmusaslsecretCRAM-MD5' since SASL_AUXPROP_AUTHZID == true I0114 15:50:03.064285 284221440 auxprop.cpp:99] Request to lookup properties for user: 'benh' realm: 'lobomacpro2.fritz.box' server FQDN: 'lobomacpro2.fritz.box' SASL_AUXPROP_VERIFY_AGAINST_HASH: false SASL_AUXPROP_OVE RRIDE: false SASL_AUXPROP_AUTHZID: true I0114 15:50:03.064291 284221440 auxprop.cpp:121] Skipping auxiliary property '*userPassword' since SASL_AUXPROP_AUTHZID == true I0114 15:50:03.064295 284221440 auxprop.cpp:121] Skipping auxiliary property '*cmusaslsecretCRAM-MD5' since SASL_AUXPROP_AUTHZID == true I0114 15:50:03.064299 284221440 auxprop.cpp:99] Request to lookup properties for user: 'benh' realm: 'lobomacpro2.fritz.box' server FQDN: 'lobomacpro2.fritz.box' SASL_AUXPROP_VERIFY_AGAINST_HASH: false SASL_AUXPROP_OVE RRIDE: false SASL_AUXPROP_AUTHZID: true I0114 15:50:03.064429 284221440 auxprop.cpp:121] Skipping auxiliary property '*userPassword' since SASL_AUXPROP_AUTHZID == true I0114 15:50:03.064438 284221440 auxprop.cpp:121] Skipping auxiliary property '*cmusaslsecretCRAM-MD5' since SASL_AUXPROP_AUTHZID == true ``` So obviously, some stackup of aux plugin requests. That effect got fixed here. - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29887/#review68061 ----------------------------------------------------------- On Jan. 14, 2015, 5:36 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29887/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2015, 5:36 p.m.) > > > Review request for mesos and Adam B. > > > Bugs: MESOS-2050 > https://issues.apache.org/jira/browse/MESOS-2050 > > > Repository: mesos-git > > > Description > ------- > > see summary. > > > Diffs > ----- > > src/authentication/cram_md5/authenticator.hpp 1819ef4 > src/authentication/cram_md5/auxprop.hpp b894386 > src/authentication/cram_md5/auxprop.cpp cf503a2 > > Diff: https://reviews.apache.org/r/29887/diff/ > > > Testing > ------- > > make check (with enhanced verbosity, GLOG_v=2 and gtest_repeat=10000) > > > Thanks, > > Till Toenshoff > >
