> On Jan. 14, 2015, 5:43 p.m., Alexander Rukletsov wrote: > > src/authentication/cram_md5/authenticator.hpp, line 465 > > <https://reviews.apache.org/r/29887/diff/1/?file=821508#file821508line465> > > > > Shouldn't this check be under the critical section? Since it's not a > > libprocess process, there is no guarantee, that no second `initialize()` > > can be called until the current one is being executed. Therefore it looks > > to me that we can still get multpile plugin instances if `initialize()` is > > called concurrently. > > Till Toenshoff wrote: > The authenticator initialize callup currently always happens during an > initialize of a libprocess-process (master, slave, frameworks). That > certainly could change in the future... So at least a TODO should be added, I > guess.
Whoops, Authenticator so certainly is only used in master. - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29887/#review68058 ----------------------------------------------------------- On Jan. 14, 2015, 5:36 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29887/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2015, 5:36 p.m.) > > > Review request for mesos and Adam B. > > > Bugs: MESOS-2050 > https://issues.apache.org/jira/browse/MESOS-2050 > > > Repository: mesos-git > > > Description > ------- > > see summary. > > > Diffs > ----- > > src/authentication/cram_md5/authenticator.hpp 1819ef4 > src/authentication/cram_md5/auxprop.hpp b894386 > src/authentication/cram_md5/auxprop.cpp cf503a2 > > Diff: https://reviews.apache.org/r/29887/diff/ > > > Testing > ------- > > make check (with enhanced verbosity, GLOG_v=2 and gtest_repeat=10000) > > > Thanks, > > Till Toenshoff > >
