----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29904/#review68217 -----------------------------------------------------------
Ship it! src/slave/main.cpp <https://reviews.apache.org/r/29904/#comment112363> Let's wrap it into Shared<> or Owned<>. - Alexander Rukletsov On Jan. 15, 2015, 12:55 a.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29904/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2015, 12:55 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-2219 > https://issues.apache.org/jira/browse/MESOS-2219 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/main.cpp 2ff2b0d186dd63e1437956e98e3682d83f2f5cd6 > src/slave/slave.hpp 70bd8c1fde4ea09fa54c76aa93424a1adb0309f6 > src/slave/slave.cpp b234f5359a91a293b93f97f035b08ef0a4c9b20d > > Diff: https://reviews.apache.org/r/29904/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Niklas Nielsen > >
