> On Jan. 15, 2015, 7:31 a.m., Alexander Rukletsov wrote: > > src/slave/main.cpp, line 179 > > <https://reviews.apache.org/r/29904/diff/1/?file=822054#file822054line179> > > > > Let's wrap it into Shared<> or Owned<>. > > Ben Mahler wrote: > That would make the code here inconsistent, are you suggesting wrapping > everything here in Owned? What about the master's main.cpp? > > And is this really an "issue" given he's following the existing style > here?
Thank you for the comment, Ben. It looks like opening an issue was the right decision: I'll learn something new about our policies in such cases. I think we still have not agreed whether we would like to use smart pointers more often (what Dominic proposes), or have raw pointers as default (BenH's suggestion). Consistency over moving forward when things change is yet another question. Maybe we should have another discussion round which ends with updating our style guide. Any standard is better than its absence. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29904/#review68217 ----------------------------------------------------------- On Jan. 15, 2015, 12:55 a.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29904/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2015, 12:55 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-2219 > https://issues.apache.org/jira/browse/MESOS-2219 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/main.cpp 2ff2b0d186dd63e1437956e98e3682d83f2f5cd6 > src/slave/slave.hpp 70bd8c1fde4ea09fa54c76aa93424a1adb0309f6 > src/slave/slave.cpp b234f5359a91a293b93f97f035b08ef0a4c9b20d > > Diff: https://reviews.apache.org/r/29904/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Niklas Nielsen > >
