-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29911/#review68275
-----------------------------------------------------------

Ship it!



src/common/resources.cpp
<https://reviews.apache.org/r/29911/#comment112449>

    This fits in one line?



src/common/resources.cpp
<https://reviews.apache.org/r/29911/#comment112450>

    Can you use ```_resources``` here?


- Jie Yu


On Jan. 15, 2015, 2:01 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29911/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2015, 2:01 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and 
> Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Added Resources(const std::vector<Resource>&). Used in 
> https://reviews.apache.org/r/29913/
> 
> 
> Diffs
> -----
> 
>   include/mesos/resources.hpp f1517b73def9aff4039f95a89f66208ba1d21c0f 
>   src/common/resources.cpp c17e1791130e7d545bb7cdd54d97d65325d3a69e 
> 
> Diff: https://reviews.apache.org/r/29911/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Reply via email to